Review Request: Add next and previous buttons to Frame applet

Anne-Marie Mahfouf annma at kde.org
Tue Jul 14 23:04:52 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1028/#review1601
-----------------------------------------------------------


Works well and I don't see anything wrong in code on a quick look. Sebas, can you take a quick look as you'll add remote URL support?
Thanks Arthur for this patch!
A pause button was also in the wish list... ;)

- Anne-Marie


On 2009-07-14 17:36:08, Arthur Mello wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1028/
> -----------------------------------------------------------
> 
> (Updated 2009-07-14 17:36:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As mentioned on Frame TODO this patch adds buttons to navigate through slide show.
> Buttons appear when mouse is over applet and only when applet is doing a slideshow.
> Example code at TODO put the buttons above the pictue, I placed them on left and right borders, but I can change this if necessary.   
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/frame.h 996678 
>   trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 996678 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 996678 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 996678 
> 
> Diff: http://reviewboard.kde.org/r/1028/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> SlideShow buttons
>   http://reviewboard.kde.org/r/1028/s/142/
> 
> 
> Thanks,
> 
> Arthur
> 
>



More information about the Plasma-devel mailing list