Review Request: Plasma::IconWidget::removeIconAction(QAction*) method add request.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/343/#review341
-----------------------------------------------------------

Ship it!


looks fine; btw, you can also just delete the QAction, though it is sensible to be able to remove the QAction without deleting it.

- Aaron


On 2009-01-24 07:25:10, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/343/
> -----------------------------------------------------------
> 
> (Updated 2009-01-24 07:25:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Yo guys, it's been a looong time since my last patch.. aanyways :D I found the need for this method while working at the DeviceNotifier refactor since i'm using IconWidget as you can see in the screenshot. I simply needed a quick way to add and *remove* the eject action, but without this method i had to delete and re-create an IconWidget. I hope this is the right way to go for this method.. Waiting for your reply, hugs =)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/iconwidget.h
>   trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/343/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/343/s/107/
> 
> 
> Thanks,
> 
> Alessandro
> 
>