Image frame bugs (trunk4.4) and possible solutions

[Darío Andrés]

2009/8/12 Darío Andrés <andresbajotierra at gmail.com>:
> * Issue 1:
>
> In Frame, when a URL is not passed to the widget constructor it
> creates an empty KUrl for "m_currentUrl" and that determines the frame
> will use the "Default" image until a custom image url is set.
> However, in the code, there are checks for "KUrl("Default")" which in
> fact isn't there; so an empty(default) image is not detected; and this
> causes some bugs (as: the "Open Image" menu option is shown and
> enabled; and when it is clicked it fails as it tries to run KRun(empty
> KUrl);
>
> Proposed fix:
> Use KUrl() (empty) and KUrl::isEmpty to check for the Default image
> (see attached patch)

I forgot to attach the patch...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: frame-default-empty.diff
Type: text/x-patch
Size: 1422 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090812/b785b4d3/attachment.diff