Review Request: moved moonphase code to time dataengine.

Aaron Seigo aseigo at kde.org
Mon Apr 27 01:35:39 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/633/#review994
-----------------------------------------------------------

Ship it!


- Aaron


On 2009-04-26 16:31:48, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/633/
> -----------------------------------------------------------
> 
> (Updated 2009-04-26 16:31:48)
> 
> 
> Review request for Plasma, Aaron Seigo and Petri Damstén.
> 
> 
> Summary
> -------
> 
> moved moonphase code to time dataengine from luna plasmoid/moonphase kicker applet (as requested by petri).
> phases.cpp is missing but it comes from the plasmoid.
> I will to remove all that useless kDebug messages.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/moonphase.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/moonphase.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 959712 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 959712 
> 
> Diff: http://reviewboard.kde.org/r/633/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>



More information about the Plasma-devel mailing list