Review Request: Device Notifier restyle: part 1

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/226/#review223
-----------------------------------------------------------


the tooltip information is nice, but the view should still popup automatically when something is plugged in. this is in direct response to a user activity, so it's ok in this case to do something non-subtle.

in this case the idea is that the user pops something in, and up pops the interface that lets them immediately open it.


trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
<http://reviewboard.vidsolbach.de/r/226/#comment179>

    doesn't need to be a member; create as needed only.



trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
<http://reviewboard.vidsolbach.de/r/226/#comment178>

    just register it; set the tooltip content on demand only using toolTipAboutToShow() and toolTipHidden()



trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
<http://reviewboard.vidsolbach.de/r/226/#comment180>

    the call to fillPreviousDevices needs to remain, otherwise it appears empty when first added even if there currently are devices there. it should probably, however, be moved to an if (constraints & StartupCompleteCosntraint) 



trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
<http://reviewboard.vidsolbach.de/r/226/#comment177>

    why is the tooltip shown in this case? shouldn't the view itself pop up?


- Aaron


On 2008-10-18 09:52:05, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/226/
> -----------------------------------------------------------
> 
> (Updated 2008-10-18 09:52:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is the first part of Device Notifier restyle. Just ported to PopupApplet + a bonus: good use of tooltips as you can see in the screenshots.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/226/diff
> 
> 
> Testing
> -------
> 
> Just works as expected
> 
> 
> Screenshots
> -----------
> 
> no device
>   http://reviewboard.vidsolbach.de/r/226/s/81/
> device plugged
>   http://reviewboard.vidsolbach.de/r/226/s/82/
> 
> 
> Thanks,
> 
> Alessandro
> 
>