Patch to mousePressEvent in Plasma lib.

Alexis Ménard menard at kde.org
Wed Nov 26 17:02:09 CET 2008


stop drug alexis
stop drug alexis

forget the last mail.

On Wed, Nov 26, 2008 at 4:54 PM, Alexis Ménard <menard at kde.org> wrote:

> Ok so i keep the reimplentation and i remove the setFocus only, and i call
> the base class.
>
> 2008/11/26 Aaron J. Seigo <aseigo at kde.org>
>
>> On Wednesday 26 November 2008, Alexis Ménard wrote:
>> > Hello,
>> >
>> > Here is a patch that remove the focus stuff in the mousePressEvent of
>> > Applet class and remove the overload. Why? Because Qt have a focus
>> policy
>> > that manage that for you. It break the binary compatibilty but it not
>> too
>> > late no? :D.
>> > I think it will avoid some future problems regarding focus.
>> >
>> > Review please?
>>
>> you can do this without breaking BC, obviously. i'd like us to get in the
>> habit of doing so and in this case it keeps the door open for adding
>> something
>> to that method if needed later on.
>>
>> --
>> Aaron J. Seigo
>> humru othro a kohnu se
>> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>>
>> KDE core developer sponsored by Qt Software
>>
>>
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20081126/f5df846d/attachment.htm 


More information about the Plasma-devel mailing list