Review Request: Fix for Favorite items in Kickoff

Jesse L. Zamora xtremek2008 at aim.com
Tue Nov 18 16:42:54 CET 2008


On Tuesday 18 November 2008 09:40:20 Aaron J. Seigo wrote:
> On Tuesday 18 November 2008, Anne-Marie Mahfouf wrote:
> > On Tuesday 18 November 2008 22:34:05 Sebastian Kügler wrote:
> > > On Tuesday 18 November 2008 13:51:45 Jesse Zamora wrote:
> > > > This patch fixes a bug with Kickoff that Favorite items have "Sort
> > > > Ascending" and "Sort Descending" even when they are not in the
> > > > favorites view. It also changes the strings to "Sort Alphabetically
> > > > (A to Z)" and "Sort Alphabetically (Z to A)". I hope I'm not too late
> > > > to get it in trunk..... :-(
> > >
> > > We're string-frozen since last night. If you want to get this patch in,
> > > separate the bugfix from the string changes. The bugfix can be
> > > committed now (it looks like a nice improvement). The string changes
> > > will have to wait until KDE is unfrozen again (somewhen in January).
> >
> > No, we're in message freeze only tonight,
>
> yes, so please commit this asap.
>
> (and once again, r-b isn't showing me the patch .. gah... )

Do you mean I can commit the new strings?


More information about the Plasma-devel mailing list