<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102069/">http://git.reviewboard.kde.org/r/102069/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 24th, 2011, 11:10 p.m., <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this now leads me to the initial thought ^^
why is PHONON_LIB_INSTALL_DIR not equipped with the '64' lib_suffix? seems a bit inconsistent that some stuff would be in lib and other in lib64, so at best I consider this a workaround, setting the cmake var LIB_SUFFIX accordingly would resolve the presented issue nicely.
that said, the proposed change, despite being sort of a workaround, is good so it is worth shipping :)</pre>
</blockquote>
<p>On July 24th, 2011, 11:14 p.m., <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">about the whitespaceness, while indeed not being explicitly mentioned I reckon it is sort of implicit from the code samples :P
staying in line with the rest of the file is certainly the rule of thumb though</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you commit this yet?</pre>
<br />
<p>- Harald</p>
<br />
<p>On July 24th, 2011, 11:03 p.m., Valentin Rusu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Phonon Backends and Harald Sitter.</div>
<div>By Valentin Rusu.</div>
<p style="color: grey;"><i>Updated July 24, 2011, 11:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GwenView crashed in Phonon-VLC module when previewing video files.
When investigating the crash, I found out that libvlc was not found on my system because the code only searched for it using the LD_LIBRARY_PATH variable. On my system, this variable wasn't set to /usr/lib64 where libvlc lives. So I adjusted the code to use ld.so.conf file which is always correctly set by the system.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GwenView no longer crashes when encountering video file, but now it's correctly previewing them :-)
I also searched for open bug reports but found no bug directly related to my issue.
However the bug 259269 may be resolved by this patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/libvlc.cpp <span style="color: grey">(4d3ed45)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102069/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>