<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100701/">http://git.reviewboard.kde.org/r/100701/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2011, 4:31 p.m., <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Splendid, I only fixed this in the GStreamer backend when I was fighting with the streamer impl. Indeed we must not indicate an error when 0 bytes were received as this is a perfectly valid scenario (e.g. when the abstractstreamer is waiting for data to arrive, like in the case of a QIODevice's read function).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://commits.kde.org/phonon-vlc/b2f9011f096bda05026fe9df4d5c552359132a07
Please close this request.
Thank you :)</pre>
<br />
<p>- Harald</p>
<br />
<p>On February 21st, 2011, 12:26 p.m., Kamil Klimek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Phonon and Phonon Backends.</div>
<div>By Kamil Klimek.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2011, 12:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">length parameter was treated as required size to read. It caused for files with id3v1 tags to end playback at begining of the file, because ret value was treated by libvlc as error. Reading id3v1 tags caused to seek almost to end of file and read not as much data as was put in length parameter. After returning length > 0 (we read at least something) everything started to work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vlc/streamreader.cpp <span style="color: grey">(89045da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100701/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>