Review Request: Emit currentSourceChanged from setSource method.

Simon Persson simonpersson1 at gmail.com
Mon Oct 29 14:09:10 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107111/
-----------------------------------------------------------

Review request for Phonon Backends and Trever Fischer.


Description
-------

Don't know why this was slashed out.. but emitting the currentSourceChanged signal from the setSource method is something that the VLC backend does and my app relies on that behavior. 


Diffs
-----

  gstreamer/mediaobject.cpp e576d2d 

Diff: http://git.reviewboard.kde.org/r/107111/diff/


Testing
-------

Just a quick check to see that my app (boombox) is now updating song label in UI when changing song in pause mode (calls setCurrentSource() but not followed by play()). Before it was only updating UI when playback started.


Thanks,

Simon Persson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20121029/1eed25cb/attachment.html>


More information about the Phonon-backends mailing list