[PATCH] make SeekSlider and VolumeSlider "swift"

Thierry Bastian thierry.bastian at trolltech.com
Fri Nov 28 10:35:52 CET 2008


Hi Tanguy,

Just had a look at the code and unfortunately GPL is not acceptable for
kdelibs, neither is it for Qt.

But the idea is still valid and I guess it is quite easy to rewrite that
code.

Regards,
Thierry

-----Original Message-----
From: Tanguy Krotoff [mailto:tkrotoff at gmail.com] 
Sent: vendredi 28 novembre 2008 09:07
To: phonon-backends at kde.org
Subject: [PATCH] make SeekSlider and VolumeSlider "swift"

Hello

Here is a patch (against latest Phonon SVN) to make SeekSlider and
VolumeSlider "swift"
This way is more user friendly: the seek goes where the user clicks (like in
VLC and other players).

The original code is from SMPlayer (developed by Ricardo Villalba
rvm at escomposlinux.org)
See
http://smplayer.svn.sourceforge.net/viewvc/smplayer/smplayer/trunk/src/mysli
der.cpp?revision=1209
So if the patch is accepted, even if it is a few lines of code (< 50), it's
better to ask him about the copyright and stuffs.
(You can see from the original myslider.cpp that Ricardo spent quite some
time to find the right solution)

Turn this behavior optional? I don't see the need since I can't find any
player doing seeking the old way.

I've tested the patch under Windows/Qt-4.4.3 for music and video playback
and everything works as expected

Thx

--
Tanguy Krotoff <tkrotoff at gmail.com>
+33 6 68 42 70 24



More information about the Phonon-backends mailing list