<br><br><div class="gmail_quote">2008/6/19 Pino Toscano <<a href="mailto:pino@kde.org">pino@kde.org</a>>:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
(please CC me for replies)<br>
<div class="Ih2E3d"><br>
> Is it ok to commit ?<br>
<br>
</div>No, it is not ok. And the reason is *exactly* what you wrote on the review<br>
board:</blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
> Perhaps we have to put this line of code directly in Plasma::PushButton to<br>
> avoid problems with other applets ?<br>
<br>
You are solving the problem in the wrong place; fixing kolourpicker will *not*<br>
fix any plasmoid using Plasma::PushButton in situation like this.<br>
</blockquote><div> <br><br>
No problem for me :). I'm totally agree that problem should be fixed directly in Plasma::PushButton <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
The fact that setMinimumSize() "is needed" to not make the buttons be drawn<br>
outside the applet (in case it is too small), smells like a Qt bug.<br>
</blockquote><div><br>Two problems :<br>The first one with the KPushButton who have a minimun size Policy : <br>Plasma::PushButton->nativeWidget()->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);<br>
<br>The second with The QGraphicProxyWidget who contains the KPushButton, (forgot to mention it on review board) :<br>Plasma::PushButton->setSizePolicy(expanding, expanding) doesn't sem to work, dont know if it is normal<br>
and effectively i have to put Plasma::PushButton-> setMinimumSize(0,0);<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Oh, and am I also against the maximum 50px threshold, setting proper size<br>
policies should work.<br>
</blockquote><div><br>i'm afraid that the applet take too much width place in horizontal panel but it is only a personal opinion ;)<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Furthermore, please leave back the 4px layout margin, otherwise the button<br>
will be too tight.<br>
</blockquote><div><br>are you ok to keep the 4x layout margin in desktop mode and remove it on panels ?<br><br>Cheers<br> <br></div></div><br>