<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d"><br>
> > * Got rid of the blacklist and revamped the load function. (Whitelists<br>
> > make more sense since the default behavior should be "plugin disabled<br>
> > by default" ie X-KDE-PluginInfo-EnabledByDefault=false)<br>
><br>
> i'm really on the fence on this one. white lists mean newly added runners<br>
> aren't automatically picked up; that actually isn't what we want here. we<br>
> should listen to EnabledByDefault, but the default should be enabled.<br>
> krunner's usefulness is really based on this concept.<br>
<br>
</div>In that case I'm adding a "load all plugin option" to the config<br>
dialog that will bypass normal behavior.<br></blockquote><div><br>Isn't blacklisting easier and more general?<br><br> </div><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d"><br>
> note that performMatch is also used for rate limiting, of course, so it<br>
> retains its usefulness.<br>
<br>
</div>Yes I noticed that part but it might have been possible to move that<br>
logic elsewhere. I also noticed that rateLimiting has been causing<br>
starvation on my end. Xesam runner gets promoted to fast runner, then<br>
starves everything else when it becomes slow again... I'll look into<br></blockquote><div><br></div></div>I have problems with the xesam runner also. I think it is a good thing to have at least one slow runner to stress krunner. Once I thought about making a test runner that just sleeps 300/400ms and then finish, Xesam runner is just perfect.<br>
<br><br><br clear="all"><br>-- <br>Jordi Polo Carres<br>NLP laboratory - NAIST<br><a href="http://www.bahasara.org">http://www.bahasara.org</a><br>