<br><br><br><div class="gmail_quote">On Sat, May 3, 2008 at 3:29 PM, Alex Merry <<a href="mailto:huntedhacker@tiscali.co.uk">huntedhacker@tiscali.co.uk</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://mattr.info:8080/r/356/" target="_blank">http://mattr.info:8080/r/356/</a><br>
-----------------------------------------------------------<br>
<br>
Review request for Plasma.<br>
<br>
<br>
Summary<br>
-------<br>
<br>
At the moment, engineexplorer will not be built if Soprano isn't found. Since it's quite a vital tool for Plasma development, this patch makes it build, but just without Soprano::Node support.<br>
<br>
<br>
Diffs<br>
-----<br>
<br>
trunk/KDE/kdebase/workspace/plasma/tools/CMakeLists.txt<br>
trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/CMakeLists.txt<br>
trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp<br>
<br>
Diff: <a href="http://mattr.info:8080/r/356/diff" target="_blank">http://mattr.info:8080/r/356/diff</a><br>
<br>
<br>
Testing<br>
-------<br>
<br>
Builds with the CMake variable WITH_Soprano set to OFF as well as ON.<br>
<br>
#warnings used to check that the expected code was compiled in or out depending on the above variable.</blockquote><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
It seems a good idea to me, to make it build either way (I did wonder if Soprano was mandatory for kdebase). I tried to look at the diff above but got an error message.</blockquote><div><br>-- Richard<br> <br></div></div>
<br>