<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-15"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Sebastian Kuegler schrieb:
<blockquote cite="mid:200803261115.58157.sebas@kde.org" type="cite">
<pre wrap="">On Wednesday 26 March 2008 11:09:43 you wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 2008-03-26 19:30, Sebastian Kuegler wrote:
</pre>
<blockquote type="cite">
<pre wrap="">... about kickoff changes.
</pre>
</blockquote>
<pre wrap="">This one is so trivial it's probably not worth a public
posting or bug report. A 1 px background color line
between the tab and the kickoff menu pane.
</pre>
</blockquote>
<pre wrap=""><!---->
Visual changes in kickoff might seem trivial, but I'd go through review
because other people think differently about this.
In any case, why should there be a line? It looks disconnected this way and
visually disturbing ...
</pre>
</blockquote>
The background pixels becomes visible because the painter is being
translated 0.5,0.5 pixels before the tabs are drawn. The translation is
necessary because otherwise half of the top-border of the painterpath
would fall outside of the visible rect thus making the tabbar look like
this: <br>
<div align="center"><img alt="stroke outside the visible rect"
title="Tabbar border" src="cid:part1.07060701.06090600@googlemail.com"
height="111" width="142"><br>
<div align="left"><br>
Top border appears to be much narrower than the rest.<br>
An obvious hack is to draw a line with the fill color to "cover up" the
background. Ugly but simple solution.<br>
The lines would be added to paintEvent() just before the painter is
being translated:<br>
<br>
-------------------------------------- Put this right before line 229
in .../kickoff/ui/tabbar.cpp ----------------------<br>
<br>
painter.setPen(QPen(palette().base(), 1));<br>
painter.drawLine(rect().topLeft(), rect().topRight());<br>
<br>
---------------------------------------------------------------------------------------------------------------------------------------<br>
<br>
The resulting tabbar then will look like this :<br>
<div align="center"><img alt="top border now looks ok"
title="kickoff tabbar" src="cid:part2.09040300.09010500@googlemail.com"
height="87" width="113"><br>
<div align="left">I've attached the patch to this email.<br>
</div>
</div>
</div>
</div>
<blockquote cite="mid:200803261115.58157.sebas@kde.org" type="cite"><br>
<hr size="4" width="90%"><br>
<center><img src="cid:part3.01070003.03050904@googlemail.com"></center>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
Panel-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/panel-devel">https://mail.kde.org/mailman/listinfo/panel-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>