<br><br><div class="gmail_quote">On Jan 1, 2008 11:38 PM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Tuesday 01 January 2008, Christopher Blauvelt wrote:<br>> Attached is a patch that allows you to align icons to a grid. Further, it<br><br></div>* there is a write- and readEntry in KConfigGroup that takes a QPointF. you
<br>don't need to do the parsing yourself (indeed, shouldn't)</blockquote><div>I'm not following which code segment you're talking about.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br>* this:<br>+ foreach (QAction *action, m_icons.contextActions()) {<br>+ actions.append(action);<br>+ }<br><br>could probably be more simply actions << m_icons.contextActions(); does the<br>same thing, just easier on the fingers ;)
</blockquote><div>Noted. At least my style was good :) <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br>* please don't remove commented out debug from,
e.g. applethandle.cpp</blockquote><div>OK <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br>* why should desktop icon locking be done separately from widget locking? this
<br>only seems to grow the artificial gulf between the two sets of functionality?</blockquote><div>I can remove it if you like. It's trivial to remove.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br>* this reminds me why i wish QActions could accept hierarchies. ActionGroups<br>aren't good enough (as they imply modality) ... adding 5 entries + 2<br>separators to the desktop menu just isn't an option though. of course, we can
<br>get rid of some of these quite easily: locking should just follow the normal<br>immutability and locking of the containment; Show Icons should go into the<br>config dialog, not the context menu;</blockquote><div>I would have liked to make a submenu to address icons but I couldn't see how that was possible given that only QAction*'s can be returned from contextMenu(). I remove Icon related items when they're not shown but if it needs to be added to the config dialog I can add the extra tab that had been previously discussed. Unless you had a different proposal.
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br>* "Line Up" should probably just be "Align", with "ly" appended to the
<br>directions</blockquote><div>Fixed. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br>* spot the formatting errors:<br><br>
+ foreach (Plasma::Applet *item, m_iconMap.values())<br>+ item->setImmutable(m_blockIcon);<br><br>and<br><br>+ if (iconsVisible) {<br>+ m_desktopDir.openUrl(KGlobalSettings::desktopPath());<br>+ }
<br>+ else {<br><br>;)</blockquote><div>Man, you're worse than my sixth-grade english teacher :) Fixed. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br>* do we need to offer a separate hook for media icons? hm.. i suppose so if<br>only because someone might want</blockquote><div>That's next to be implemented. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br>* i assume the icon.h and icon.cpp bits aren't intended as part of the diff?</blockquote><div>Oops! Thats a start at my attempt to allow dragging of icons by clicking and dragging from the middle. I guess I need to do an "svn diff" from a little farther down in the directory.
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><font color="#888888"><br>--<br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
<br><br>KDE core developer sponsored by Trolltech<br></font><br>_______________________________________________<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">
https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div><br>