<br><br><div class="gmail_quote">On Dec 10, 2007 8:10 PM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Monday 10 December 2007, William Egert wrote:<br>> On Dec 10, 2007 7:39 PM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br></div><div class="Ih2E3d">> clock 3 times for the calendar to be displayed. This patch fixes the
<br>> clock,<br><br></div>ah, something i forgot to mention that i noticed on first read of the patch is<br>that you should not be initializing the dialogs in the constructor. that just<br>slows down start up time and may unecessarily use up memory (what if the user
<br>never clicks to get the calendar?) ... there's a reason it is initialized in<br>the mouseClickEvent =)</blockquote><div><br>That makes sense, I suppose the important thing is that it is deleted in the constructor.
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br>also, i'm not sure what the point of m_calendarIsShown is when one can simply
<br>query isVisible()?</blockquote><div><br>This is unused in the second patch, showing the calender would toggle on this bool, but with the 2nd patch it would not be necessary.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br>apologies for not putting that in the earlier email...</blockquote><div><br>see above :) <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><div class="Ih2E3d"><br>> but it does look like Plasma::Dialog eats up a click event? For<br>> example, if i click so the calender is displayed, and then click on an open<br>> application, the calendar will hide, but the application did not gain
<br>> focus.<br><br></div>that would be a side effect of setting the calendar window type to Popup.<br>personally, i'd set it to be a toolbox window and only close it on an<br>explicit close.</blockquote><div><br>not sure if its up to me to make that call .
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><font color="#888888"><br>--<br></font><div><div></div><div class="Wj3C7c">Aaron J. Seigo
<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech<br></div></div><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">
</a></blockquote><div><br>-Bill <br></div></div><br>