[PATCH] Config Dialog for Runners

[Aaron J. Seigo]

On Sunday 18 May 2008, Ryan P. Bitanga wrote:
> Anyway, attached is a preliminary patch to support a config dialog for
> KRunner.

hm .... this is really bad timing =) we are hoping to get a series of changes 
in tomorrow to beat the feature freeze and have a branch going .. this will 
need to be merged into the branch. =/

also, we'll need to take scripting into consideration with the change to a kcm

KConfigGroup* RunnerManager::config() should be KConfigGroup 
RunnerManager::config() (no pointer)

we'll need to allow for scripting somehow with regards to the configuration 
now that it uses KCMs instead. hm... not sure how to do that off hand, but it 
will need to get done.

i'm still not overly happy about the whitelist approach as it means every 
newly installed runner will need to be added either by the user (not 
desirable) or automatically with the right key in the config file ... 
essentially working around the policy. what we really want is an opt-in 
blacklist, not an opt-in whitelist.

the big issue, however, is the timing of this. i'd say commit everything, but 
please change the whitelisting approach. commit either within the next 12 
hours so that a merge can be done with the branch or else hold off and wait 
for 4.2. =( in fact here's what i'll do: if you don't get it committed by 
noon my time i'll just commit it for you with some modifications so that i 
can also merge it into the branch and be done with it.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080519/466c2f80/attachment.pgp