Themes and Panels

[Aaron J. Seigo]

On Saturday 22 March 2008, Ivan Čukić wrote:
> > >  - setPrefix resets location
> >
> > i wonder if the check for existence shouldn't go here instead of in
> > generateBackground? that way it's always guaranteed that the the prefix
> > is valid.
>
> The problem lies in the event of setFile() invoked after setPrefix()
>
> BTW, shouldn't setFile() (and setPrefix() for that matter) clear the cache?

that's why setFile calls updateSizes(). in fact... what should probably happen 
is setFile() should change from:

    d->background->setFile(imagePath);
    updateSizes();

to

    d->background->setFile(imagePath);
    setPrefix(prefix());

and setPrefix should call updateSizes() at the end of it, and updateSizes() 
needs to use the prefix when figuring out the sizes.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080322/49eee05a/attachment.pgp