Review Request: Delay applet handle creation
Aaron Seigo
aseigo at kde.org
Sat Mar 15 00:10:21 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/300/#review301
-----------------------------------------------------------
this is a very thorough approach to the problem.
however, this was already taken care of with the delay to showing and the keeping of the handles list. i guess the TODO wasn't removed =(
i don't think we need another list of queued handles when the existing list is enough, really.
anyways, applet handle needs to be merged into Applet as a QGraphicsView "window decoration" which will help make these things a lot easier.
- Aaron
On 2008-03-14 17:40:43, David Benjamin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/300/
> -----------------------------------------------------------
>
> (Updated 2008-03-14 17:40:43)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> (Okay, hopefully I did this right... was told to use this site from Bug 159330 on bugzilla.)
>
> There's a TODO in plasma's containment.cpp,
> "TODO: there should be a small delay on showing these. they pop up too quickly/easily right now"
>
> I've taken a shot at implementing it. Is this satisfactory?
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/libs/plasma/applethandle_p.h
> trunk/KDE/kdebase/workspace/libs/plasma/containment.h
> trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
> trunk/KDE/kdebase/workspace/libs/plasma/applethandle.cpp
>
> Diff: http://mattr.info/r/300/diff
>
>
> Testing
> -------
>
> ran plasma with it, works here
>
>
> Thanks,
>
> David
>
>
More information about the Panel-devel
mailing list