Review Request: Animates tabswitching
Marco Martin
notmart at gmail.com
Mon Mar 10 18:02:16 CET 2008
> On 2008-03-10 10:00:07, Marco Martin wrote:
> > i think it looks good, both in code and visually
>
> Will Stephenson wrote:
> Can we hold off committing this? I found it too slow, and frankly, redundant to have an animation here at all.
>
> Mehdi Salem Naraghi wrote:
> Well the speed of the animation can be increased but I must admit that it feels slower than the animation done using the QTimeLine. I did however use 150ms in both situations so its probably a Phase issue. It's just a perception though and I might be wrong.
>
> Mehdi Salem Naraghi wrote:
> Btw, I think the animation looks good and is not redundant at all.
it has the same speed of the animation of the icon, so i don't think it somewhat collides with it, i think it looks pretty good.
maybe is the distance that the tab travel for instance if it goes from the first to the last? maybe a fade out of the old tab together a fade in of the new one would be less appariscent? (but maybe more complicate code because two tabs should be rendered at the same time)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/278/#review278
-----------------------------------------------------------
On 2008-03-09 07:11:19, Mehdi Salem Naraghi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/278/
> -----------------------------------------------------------
>
> (Updated 2008-03-09 07:11:19)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Adds a nice transition animation during a tabswitch . The code now uses Phase::customAnimation() instead of the former QTimeLine.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
>
> Diff: http://mattr.info/r/278/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehdi
>
>
More information about the Panel-devel
mailing list