Review Request: Themed task item backgrounds

Jamboarder jamboarder at yahoo.com
Fri Mar 7 17:42:26 CET 2008


For some reason I'm getting undelivered mail messages when I submit this on review board (worked fine for previous review requests).  Anyway, I've cut and paste it below.

- Andrew 

===============================

Review request for Plasma.


Summary
-------

This patch allows task item backgrounds to be painted using a theme svg file.  The svg file used widgets/tasks.svg and should contain the following elements: focus, hover, attention and normal.  If the svg file is absent then the backgrounds are painted as they do currently.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h

Diff: http://mattr.info/r/262/diff


Testing
-------

Tested with simple proof-of-concept tasks.svg available here: http://www.mediafire.com/?1k1zjk3nu3d

No problems that I noticed.


Thanks,

Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/262/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch allows task item backgrounds to be painted using a theme svg file.  The svg file used widgets/tasks.svg and should contain the following elements: focus, hover, attention and normal.  If the svg file is absent then the backgrounds are painted as they do currently.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h

Diff: http://mattr.info/r/262/diff


Testing
-------

Tested with simple proof-of-concept tasks.svg available here: http://www.mediafire.com/?1k1zjk3nu3d

No problems that I noticed.


Thanks,

Andrew




More information about the Panel-devel mailing list