Review Request: rounded borders to dialogs

[Luboš Luňák]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/258/#review240
-----------------------------------------------------------


There's no need to make the shape optional only when compositing is disabled - just because compositing hides the problem that doesn't mean the problem is not there.


- Luboš


On 2008-03-05 07:34:28, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/258/
> -----------------------------------------------------------
> 
> (Updated 2008-03-05 07:34:28)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes rounded borders to dialogs when compositing is not active just like the tooltips.
> -since the check if compositing is active is done in many places i added it to Plasma::Theme since it was already keeping track of it (does this makes sense?)
> -tooltips had a rounded borders radius hardcoded of 10px, i made a new svg element (and consequent access functions in svgpanel) hint-round-radius to retrieve the size for pixmap based svgs it must be something like an external square, for vector based it could be an element inner to for instance the topleft corner id
> -krunner is still missing, i've not touched it atm since is in the process of becoming "good enough for aaron"(tm) :P
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/opaque/dialogs/background.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/opaque/widgets/tooltip.svg
> 
> Diff: http://mattr.info/r/258/diff
> 
> 
> Testing
> -------
> 
> tested tooltips and some dialogs also with svg that don't have the hint-round-radius element: they simply become squared
> 
> 
> Thanks,
> 
> Marco
> 
>