Review Request: Yet another Kickoff hover effect proposal

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/235/#review218
-----------------------------------------------------------

Ship it!


ah, icon size fixes. nice...

ok, let's go with this for now. it's an improvement if only for the other bug fixes in it ... we can continue to improve it as we go (e.g. making the icon 'grow' as well ala Alex's patch)


- Aaron


On 2008-02-29 11:43:10, Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/235/
> -----------------------------------------------------------
> 
> (Updated 2008-02-29 11:43:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Since it seems that nowadays creating new hover effects in Kickoff for random reasons is the new trend, I thought why not me?
> So here it is, it's full width but it's only painting an outline. I think it nicely address some of the concerns people had so far:
>  - it tries to paint as little as possible of the empty space, not dragging attention to it;
>  - it keeps the icon on a neutral background, it's not on highlight color;
>  - and we visually get the grouping of icon, text and arrow together.
> 
> If it gets in, one of the obvious improvements would be to use a gradient to draw the outline. Unfortunately, I didn't manage to get a nice result with my poor knowledge of QGradient and friends so for now it's plain solid.
> 
> --
> 
> Now integrates the "icon become bigger proposal":
>  - icons are biggers on hovered items
>  - text is bold on hovered items
>  - sanitize some of the size handling in kickoff to avoid the "blurry icon on hover"
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/flipscrollview.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/urlitemview.cpp
> 
> Diff: http://mattr.info/r/235/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Screenshot in the applications tab
>   http://mattr.info/r/235/s/29/
> 
> 
> Thanks,
> 
> Kevin
> 
>