KDE/kdebase/workspace/plasma/applets/kickoff/ui

Aaron J. Seigo aseigo at kde.org
Thu Feb 28 10:35:26 CET 2008


SVN commit 780192 by aseigo:

i'm not sure what part of this was hard to understand, but evidently it wasn't communicated quite clearly enough. so let's try again:

extending the "sea of highlight()" rect to the full option.rect is not acceptable. if you want to see full width selections, do them up right. but clashing with icons, with usage bars and emphasizing negative space is not an option.

if you really, really dislike rect-behind-text-only then i encourage you to really, really come up with a solution, not something that satisfies you enough to ignore how stupidly *bad* it ends up looking.

and no, i'm not buying any of the BS 'usability' reasoning because *none* of the issues raised have *one iota* of basis in reality. this is an aesthetics issue, so do it aesthetically proper. or not at all.

CCMAIL:panel-devel at kde.org


 M  +1 -1      itemdelegate.cpp  


--- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp #780191:780192
@@ -118,7 +118,7 @@
         // for the background
         backgroundColor.setAlphaF(0.5);
         painter->setBrush(QBrush(backgroundColor));
-        painter->drawPath(Plasma::roundedRectangle(option.rect, 5));
+        painter->drawPath(Plasma::roundedRectangle(textAreaRect, 5));
         painter->restore();
     }
 


More information about the Panel-devel mailing list