Review Request: changes to panel sizing code

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/219/#review196
-----------------------------------------------------------


does this override the ability for the user to set the size themselves?

- Aaron


On 2008-02-25 05:04:43, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/219/
> -----------------------------------------------------------
> 
> (Updated 2008-02-25 05:04:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is a fairly ugly patch.the idea was to remove the size entry from the panel config and magically calculate it from the geometry. right now it has one big bug: if there's no config file the size will default to 40 instead of 48, because of some magic somewhere else that makes the panel+border 40x48 at some point. I think that might maybe be solvable by having corona load containments' constraints before init instead of after. however, given how ugly my code is right now, I'm not sure whether it's worth finishing this patch, seeing as trunk will probably make it all unnecessary soon. should I keep working on it or go do something else?
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/219/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>