Review Request: Cleanup Notes Applet

Sebastian Kuegler sebas at kde.org
Mon Feb 11 13:08:11 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/109/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

- codingstyle cleanups
- Remove Notes-internal size handling, that's done by plasma itself
- Remove unecessary saveNote(), we can do just fine with only one method saving the content

Result: 
-1 String
- 3 methods
- 1 member var
- ~80 LOC

Without visible regressions :-)


Diffs
-----

  /trunk/extragear/plasma/applets/notes/config.ui
  /trunk/extragear/plasma/applets/notes/notes.h
  /trunk/extragear/plasma/applets/notes/notes.cpp

Diff: http://matt.rogers.name/r/109/diff


Testing
-------

Compiled, resized, quit, restarted, all work as expected (modulo chani's remarks which should be in the queue)


Thanks,

Sebastian



More information about the Panel-devel mailing list