Review Request: Always single click in panel icons

[Marco Martin]

On Sunday 10 February 2008, Christopher Blauvelt wrote:
> Why don't we just get rid of the activated signal and have the applet
> determine whether to open the URL or not?  In other words, have the applet
> connect to clicked if it's in the panel or KGlobalSettings says to
> otherwise connect to doubleclick.  It seems that activated is rather
> presumptuous since the Icon doesn't know anything about the context.
uhm, activated follows kglobalsettings, why duplicating the check up in the 
applet?

Cheers,
Marco Martin

> Chris
>
> On Feb 10, 2008 9:41 AM, Marco Martin <notmart at gmail.com> wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://matt.rogers.name/r/100/
> > -----------------------------------------------------------
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > Ok, this change is pretty trivial but changes the behaviour, so... :)
> > when an icon applet is is the panel always activate it with the single
> > click regardless of single/double click settings, don't think it makes
> > much sense to activate them with double click, because i have serious
> > problem to consider the panel a file manager view :)
> > and maybe when/if the desktop folder will be visualized by its own
> > plasmoid i think using always single click even in the desktop would make
> > sense, but for now i would go single or double in the desktop and single
> > in the panel
> >
> >
> > Diffs
> > -----
> >
> >  /trunk/KDE/kdebase/workspace/plasma/applets/icon/icon.cpp
> >
> > Diff: http://matt.rogers.name/r/100/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Marco
> >
> > _______________________________________________
> > Panel-devel mailing list
> > Panel-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/panel-devel