Review Request: changes to comic applet and dataengine and an osnews provider

[Marco Martin]

> On None, Bill Egert wrote:
> >
> 
> Marco Martin wrote:
>     hmm, i'm still not confortable on choosing when using a class from kde and when using one from qt, it seems plasma many times prefers the most generic ones, the comic engine for instance used already qurls and the qhttp class instead of kio, is this a mistake? maybe (it doesn't follow proxy settings)
>     i was using qurl because i assumed these would be always simple http urls, so i didn't needed the extra complexity of kurl
>     what particular shortcomings would have the use of qurl instead of kurl?
> 
> Riccardo Iaconelli wrote:
>     well, I think it's better to use kurl over QUrl... after all, it's just a find&replace for you, but ensures flexibility...
>     probably it won't change much for plain http, but as the docs say, kurl has to be preferred. you never know what it could be used for. ;-)
>     
>     It will also (possibly) be able to follow proxy settings with kurl, although I'm not sure at all about this, just guessing.

ok, KUrlIfied ;)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/47/#review23
-----------------------------------------------------------


On 2008-02-03 09:05:52, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/47/
> -----------------------------------------------------------
> 
> (Updated 2008-02-03 09:05:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is a quite massive change to the comic applet, yeah i know quite hard to review sorry for that.
> the main chanea are:
> -i've added a provider to http://www.osnews.com/comic (got permission from them) it uses a rss feed so only last 15 will be available but i think is enough
> -now the applet can be resized (option that can be disabled if you want to see the comic as is)
> -the dataengine now giver more data that can also be cached at the moment it has only the url of the comic of the day, but i plan to use it also to pass the date of the previous and the next comic (useful for comics that don't have a strip every day)
> -the url of the comic is displayed at the bottom of the applet and clicking on it it opens a web browser on that page (useful if the comic is scaled down and some (osnews) explicitly asks it)
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/plasma/applets/comic/CMakeLists.txt
>   /trunk/extragear/plasma/applets/comic/comic.h
>   /trunk/extragear/plasma/applets/comic/comic.cpp
>   /trunk/extragear/plasma/applets/comic/configdialog.h
>   /trunk/extragear/plasma/applets/comic/configdialog.cpp
>   /trunk/extragear/plasma/applets/comic/configimg.qrc
>   /trunk/extragear/plasma/applets/comic/pics/osnews.png
>   /trunk/extragear/plasma/dataengines/comic/CMakeLists.txt
>   /trunk/extragear/plasma/dataengines/comic/cachedprovider.h
>   /trunk/extragear/plasma/dataengines/comic/cachedprovider.cpp
>   /trunk/extragear/plasma/dataengines/comic/comic.h
>   /trunk/extragear/plasma/dataengines/comic/comic.cpp
>   /trunk/extragear/plasma/dataengines/comic/comicprovider.h
>   /trunk/extragear/plasma/dataengines/comic/comicprovider.cpp
>   /trunk/extragear/plasma/dataengines/comic/dilbertprovider.h
>   /trunk/extragear/plasma/dataengines/comic/dilbertprovider.cpp
>   /trunk/extragear/plasma/dataengines/comic/garfieldprovider.h
>   /trunk/extragear/plasma/dataengines/comic/garfieldprovider.cpp
>   /trunk/extragear/plasma/dataengines/comic/snoopyprovider.h
>   /trunk/extragear/plasma/dataengines/comic/snoopyprovider.cpp
>   /trunk/extragear/plasma/dataengines/comic/userfriendlyprovider.h
>   /trunk/extragear/plasma/dataengines/comic/userfriendlyprovider.cpp
>   /trunk/extragear/plasma/dataengines/comic/xkcdprovider.h
>   /trunk/extragear/plasma/dataengines/comic/xkcdprovider.cpp
> 
> Diff: http://matt.rogers.name/r/47/diff
> 
> 
> Testing
> -------
> 
> -tried the osnews provider with every comic they've published for now
> -scaling down a comic if not all the strips have the same size it keeps the right aspect ratio for every comic
> -tried the link with all the comics
> -xkcd comic seems broken, was it broken already (i'll do some tests)
> 
> 
> Thanks,
> 
> Marco
> 
>