[Panel-devel] engines, applets and timing

[Michael Olbrich]

Hi,

On Wed, Sep 12, 2007 at 12:10:23PM -0600, Aaron J. Seigo wrote:
> is there anyone interested in going through the existing engines and making 
> the necessary changes? those would be: getting rid of engine-global update 
> timers and implementing updateSource(const QString&) where appropriate.

I think I have some time for that later today. But first some fixes for
that new stuff:

1)
uint timeSinceLastUpdate() const;
to
int timeSinceLastUpdate() const;

it avoids signed/unsigned comparison and internally it's an int anyway.


2)
d->relays.erase(d->relays.find(relay->m_interval));
to
d->relays.remove(relay->m_interval);

in this case it's the same but nicer.

3)
in DataContainer::connectVisualization d->relayObjects[visualization]
was not set for (updateInterval >=3D1)
and related to that fix:
QObject* DataContainer::Private::signalRelay
to
SignalRelay* DataContainer::Private::signalRelay

to avoid casting

4)
it's not possible to disconnect during QObject::destroyed()
checking the sender is a bit ugly but I didn't feel like writing an
extra slot?

5)
DataEngine::setupdateInterval
should be
DataEngine::setUpdateInterval

right?

6) (not yet implemented)
I would like to change minUpdateFreq to minUpdateInterval because that's
what it acually is.

patch for 1-5 attached. ok to commit?

michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: misc.diff
Type: text/x-diff
Size: 6246 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070916/be38154f/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070916/be38154f/attachment.pgp