<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><br></div><div>On Mar 14, 2013, at 7:09 PM, Georg Ehrke <<a href="mailto:oc.list@georgehrke.com">oc.list@georgehrke.com</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div><br></div><div>On Mar 14, 2013, at 6:40 PM, Jan-Christoph Borchardt <<a href="mailto:hey@jancborchardt.net">hey@jancborchardt.net</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">It’s good to have more review going on for the apps of course and I agree with most of your suggestions.<div><br></div><div>Creating a central repo for the apps and centralizing all testing is the wrong solution though I think.</div></div></div></blockquote>We need a centralized repo for united tests </div></blockquote>* unit tests (damn autocorrect)<br><blockquote type="cite"><div>and automated penetration testing. At least, it makes it easier to run these tests.<br><blockquote type="cite"><div><div dir="ltr"><div>Who should do the testing?</div></div></div></blockquote>Mr. Jenkins<br><blockquote type="cite"><div><div dir="ltr"><div>We have few people as it is, and we need to work on other things. 3rd party devs should happily be able to develop on their own turf and with their own methods.</div>
<div><br></div><div style="">Reviewing boils down to: Install the app, click around, look into the console. Does it work? Are there any errors? Is it fun to use?</div><div style=""><br></div><div style="">That’s just something people need to do, and at the end great apps get the »Recommended« stamp, and all apps get feedback about what was good and bad and what to improve. No big scaffolding needed and especially not another centralized repo as dump for all apps.</div>
<div style=""><br></div><div style=""><br></div><div style=""><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 14, 2013 at 6:26 PM, Georg Ehrke <span dir="ltr"><<a href="mailto:oc.list@georgehrke.com" target="_blank">oc.list@georgehrke.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
I would like to start a discussion about our apps review process.<br>
There already is a review process for apps on <a href="http://apps.ownCloud.com" target="_blank">apps.ownCloud.com</a>, but imho it's not working as it's supposed to be.<br>
There are no discussions about new / updated apps and it's just not working out.<br>
<br>
My proposal:<br>
We have to make it easier for reviewers to review apps.<br>
We should create an <a href="http://apps.ownCloud.com" target="_blank">apps.ownCloud.com</a> repo on GitHub.<br>
<br>
My approach for a new workflow:<br>
If one submits a new / updated app, it will be pushed to this repository.<br>
This will enable reviewers to simply take a look at the diff of an updated app and discuss changes directly on GitHub.<br>
Reviewers will be able to give :+1: or :-1: to show if they would like to approve or refuse the update.<br>
We will also be able to run unit tests and automated penetration testing.<br>
<br>
Update apps guidelines:<br>
- only one bug fix / feature update may be submitted a day<br>
- I really appreciate the afford developers put in their apps, but all reviewers are volunteers, who don't have time to approve the same app five times a day<br>
- this rule doesn't apply if the update contains security fixes.<br>
<br>
I am not sure, if we should add these rules as well. Feedback please.<br>
<br>
- the app must use the ownCloud Public API<br>
- it may not come without unit tests<br>
<br>
Other minor changes to <a href="http://apps.ownCloud.com" target="_blank">apps.ownCloud.com</a>:<br>
If an app was not approved yet, one should be able to download the old version(, except there is a known security issue).<br>
<br>
Cheers<br>
<span class="HOEnZb"><font color="#888888">Georg Ehrke<br>
_______________________________________________<br>
Owncloud mailing list<br>
<a href="mailto:Owncloud@kde.org">Owncloud@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/owncloud" target="_blank">https://mail.kde.org/mailman/listinfo/owncloud</a><br>
</font></span></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Owncloud mailing list</span><br><span><a href="mailto:Owncloud@kde.org">Owncloud@kde.org</a></span><br><span><a href="https://mail.kde.org/mailman/listinfo/owncloud">https://mail.kde.org/mailman/listinfo/owncloud</a></span><br></div></blockquote></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Owncloud mailing list</span><br><span><a href="mailto:Owncloud@kde.org">Owncloud@kde.org</a></span><br><span><a href="https://mail.kde.org/mailman/listinfo/owncloud">https://mail.kde.org/mailman/listinfo/owncloud</a></span><br></div></blockquote></body></html>