
<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>Am 18.05.2012 um 12:07 schrieb Frank Karlitschek:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On 18.05.2012, at 11:57, Georg Ehrke <<a href="mailto:ownclouddev@georgswebsite.de">ownclouddev@georgswebsite.de</a>> wrote:<br><br><blockquote type="cite">Hi Frank<br></blockquote><blockquote type="cite">Am 18.05.2012 um 11:46 schrieb Frank Karlitschek:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">Hi,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">I need some help for debugging a strange behavior that I don't understand.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Please click on the "All versions"  button on the history dropdown of a file on current master<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">The button links to an url similar to this:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">/owncloud/apps/files_versions/history.php?path=/hfghhggfhgh<br></blockquote></blockquote><blockquote type="cite">1.<br></blockquote><blockquote type="cite">On line 28 of versions.js you should take the parameters out of the OC.filePath call. <br></blockquote><br>Not sure what you mean. There is no OC.filePath in line 28<br>Can you look into this please?<br></div></blockquote>I meant OC.linkTo,</div><div>It's fixed <font class="Apple-style-span" color="#4e4e4e" face="'Helvetica Neue', Helvetica, Arial, sans-serif"><span class="Apple-style-span" style="line-height: 17px;">(<a href="https://gitorious.org/owncloud/owncloud/commit/73a72054a3e08b62e4f28c9c622f98b4737efeff">https://gitorious.org/owncloud/owncloud/commit/73a72054a3e08b62e4f28c9c622f98b4737efeff</a>)</span></font><blockquote type="cite"><div><br><br><br><blockquote type="cite">2.<br></blockquote><blockquote type="cite">You use nginx, right?<br></blockquote><blockquote type="cite">There is a RewriteRule (/owncloud/apps/files_versions/history.php?path=/hfghhggfhgh -> /owncloud/?app=files_versions&getfile=history.php&path=/hfghhggfhgh) which (probably) doesn't work with nginx.<br></blockquote><br>No. I use apache.<br>But we shouldn´t rely on rewrite rules to make this work. rewrite rules don´t work always and are not portable<br>So the best would be to remove them completely so that we can check what breaks.<br><br><br><br><br><br><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">unsurprisingly the page shows this error:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Fatal error: Class 'OCP\User' not found in /var/www/owncloud/owncloud/apps/files_versions/history.php on line 24<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">This makes sense because history.php doesn´t include any of our libraries or sets any include path.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">This should only work with the movable apps systematic "?apps=foo&file=bar"<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Can someone reproduce this behavior? Because it seems that this is working for everybody else beside me. ;-)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Thanks for the feedback<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite">Cheers,<br></blockquote><blockquote type="cite">Georg<br></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Frank<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Owncloud mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:Owncloud@kde.org">Owncloud@kde.org</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="https://mail.kde.org/mailman/listinfo/owncloud">https://mail.kde.org/mailman/listinfo/owncloud</a><br></blockquote></blockquote></div></blockquote></div><br></body></html>