When i so this post i was very glad that finaly you're fixing owncouds bigest problem: Total lack of designe.<br>So you didnt use a library and mvc or some other designe pattern from the getgo. Ok nothing we can do about that.<br>
<br>But urlrouting is a very basic thing that has implications way beyond astetic looks. Last time i coded on owncoud an API and an easy way to interface plugins was just a wet dream.<br><br>But maby it's just me.<br>
<br clear="all">Lp<br>Rok Andrée<br>
<br><br><div class="gmail_quote">On 14 March 2012 13:49, Frank Karlitschek <span dir="ltr"><<a href="mailto:frank@owncloud.org">frank@owncloud.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 14.03.2012, at 01:46, Roland van Laar <<a href="mailto:roland@micite.net">roland@micite.net</a>> wrote:<br>
<br>
> Hello,<br>
><br>
<br>
Hi Roland,<br>
<br>
thank you for your contribution.<br>
<div class="im"><br>
<br>
> I added a url routing feature to owncloud.<br>
> For now only the root index and the files/index.php work.<br>
> lib/setup.php is also patched to setup a correct .htaccess when it's deployed behind Apache.<br>
<br>
</div>How does it work if ownCloud is running on a webserver other than apache or if rewrite support is not installed or the user is not allowed to configure rewrites in .htaccess or can´t use .htaccess files at all?<br>
<br>
One of the main design goal of ownCloud is that is should run on as many servers as possible without problems and don´t require manual configuration from the user.<br>
<div class="im"><br>
<br>
> One of the reasons to add urlrouting is to allow for cleaner urls in owncloud.<br>
> It's now possible to remove the .php ending for example.<br>
> Another reason is increased security because with urlrouting only files<br>
> included in the url patterns are called from apache.<br>
> The other files, such as 3rd party libraries are now only accessible via code.<br>
<br>
</div>I don´t really see the benefit for ownCloud here. ownCloud is a personal space for files and data and not a public website. So we don´t need to care about SEO urls or Google or how convenient it is to remember, tweet or mail urls. I agree that shorter urls without .php are prettier from an esthetics standpoint but this benefit is not strong enough to justify to make ownCloud incompatible with a lot of our users.<br>
<div class="im"><br>
<br>
><br>
> A dispatch.php is added which becomes the starting point for all non img,ajax, css and js requests.<br>
> dispatch.php contains the starting point for urls.<br>
><br>
> An example url patterns:<br>
> $urlPatterns = Array(<br>
> Array('url' => '^/$', 'file' => 'index.php'),<br>
> Array('url' => '^/index.php$', 'file' => 'index.php'),<br>
> Array('url' => '^/files', 'dir_include' => 'files/'),<br>
> );<br>
><br>
> It's possible to include urls.php files in other directories via the<br>
> 'dir_include' => dir_name syntax in the Array.<br>
><br>
> The code: <a href="https://gitorious.org/%7Ervanlaar/owncloud/rvanlaars-owncloud-urlrouting" target="_blank">https://gitorious.org/~rvanlaar/owncloud/rvanlaars-owncloud-urlrouting</a><br>
><br>
> What do you think?<br>
> Is this something that has the potential to be included in owncloud?<br>
<br>
<br>
</div>I´m really sorry to say but I think that your proposal is not suitable for ownCloud at the moment.<br>
I hate to say this to a new contributor but I hope you understand the reason.<br>
<br>
I suggest to post to this mailing-list earlier next time if you propose big architectural changes so that we can discuss this before you spend a lot of time coding. :-)<br>
<br>
<br>
There are a lot of areas in ownCloud where we need help.<br>
<br>
If you need some inspiration you can have a look at:<br>
<a href="http://owncloud.org/dev/junior-jobs/" target="_blank">http://owncloud.org/dev/junior-jobs/</a> or<br>
<a href="http://bugs.owncloud.org/" target="_blank">http://bugs.owncloud.org/</a><br>
<br>
<br>
It would be awesome if you would help us to improve ownCloud in other areas and become a contributor.<br>
<br>
Thanks a lot :-)<br>
<br>
Cheers<br>
<span class="HOEnZb"><font color="#888888">Frank<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
Owncloud mailing list<br>
<a href="mailto:Owncloud@kde.org">Owncloud@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/owncloud" target="_blank">https://mail.kde.org/mailman/listinfo/owncloud</a><br>
</div></div></blockquote></div><br>