<table><tr><td style="">yegori added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25628">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25628#569866" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25628#569866</a>, <a href="https://phabricator.kde.org/p/davidhurka/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidhurka</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hey Yegor, I like this idea.</p></div>
</blockquote>
<p>Hi <a href="https://phabricator.kde.org/p/davidhurka/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidhurka</a>, thank you</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I’m not sure what you mean with adding visual controls.<br />
Currently, auto-scrolling has no menu entries. Do you think there should be menu entries?</p></blockquote>
<p>I think it would be nice to have play/pause sort of button on instruments panel for example, but it is not required. <br />
After using my prototype for a while I can say that next thing I would like it to have is a sort to easily set the auto-scroll speed. <br />
As of right now there is no any indication what current speed is, and I have to just blindly click several times Shift+Down and Shift+Up to find the right speed.<br />
So it'd be very handy to have some way to set desired speed (i.e. using QSlider widget or free text input field with numeric values and up and down buttons) and then just "start" auto-scroll (with "play" button I mentioned before or special key binding, but visual element would encourage users to try and appreciate the new feature)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Or do you want a switch between the current auto-scroll behaviour and the new one? I think that can go into the settings (<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Configure Okular...</span></span></span>).</p></blockquote>
<p>Yes, this kind of switch between current and new scrolling behavior can go into (<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Configure Okular...</span></span></span>), but I don't have strong opinion on this.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I think you are aware of {naw Continuous} view mode. Auto-scrolling currently requires {nav Continuous) to be useful. For your suggested auto-scroll behaviour it will be the same, right?</p></blockquote>
<p>Yes, I guess so.</p>
<p>Here's the list of thing to keep in mind a long the way:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Auto-scroll speed is now determined as pixels/ms. I think it would be better if speed was determined by pages/minute, as right now there is a third factor which affect the actual time you have to read a page, which is view port height. If I set scale factor to fit page and I have speed 10 pixels per second and my viewport is 200 pixels height I'll have 20 seconds to read a page. If a make viewport twice bigger it will take 40 seconds to scroll the page, which should be the case to my mind.</li>
</ol>
<p><strong>Note</strong> Super cool extra feature would be to be able to set scroll speed based on words/minute, as distribution of text is not always equal along the page, and now, having constant scrolling speed, I usually have to compensate that by scrolling down with mouse wheel from time to time to make auto-scroll to catch up with where I'm reading.</p>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Currently auto scroll can be turned off by many different actions, such as pressing buttons, clicking mouse anywhere in viewport and others. I think that other scrolling methods shouldn't stop auto-scroll, for example if the page is left blank I should be able to press "page down" without stopping auto-scroll. I think there should be couple of methods to pause/resume auto-scroll, such as pressing space button, clicking left mouse button (on another click scroll resumes, or scroll resumes as soon as button is released, not sure yet), couple of ways to stop auto-scroll (for example special key binding, button in instruments panel). Difference between pause and stop is that after pause there are event which resume scroll, after stop those events don't resume scroll. Apart from that auto-scroll shouldn't be interrupted by any other actions.</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25628">https://phabricator.kde.org/D25628</a></div></div><br /><div><strong>To: </strong>yegori, VDG, Okular<br /><strong>Cc: </strong>davidhurka, ndavis, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid<br /></div>