<table><tr><td style="">simgunz added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15580">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15580#inline-141818">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidhurka</span> wrote in <span style="color: #4b4d51; font-weight: bold;">shell.cpp:370</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This (maybe) causes one problem now. The default is to open new documents in new windows.</p>

<p style="padding: 0; margin: 8px;">Open a new document with the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open</span></span></span> action of an existing shell, so a new Okular window appears. Open the annotation toolbar in both windows. Click <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Hide</span></span></span> in the second window. -> Only the annotation toolbar in the first window is closed.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Good that you spotted this bug, though it is unrelated to this change (I think). If you use <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Tools</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Annotations</span></span></span> or the shortcut <tt style="background: #ebebeb; font-size: 13px;">F6</tt> everything is working correctly. The problem is only related to the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Hide</span></span></span> buttton in the toolbar. I indeed expected some weird behavior somewhere.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15580#inline-141882">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationactionhandler.cpp:492</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QAction</span> <span style="color: #aa2211">*</span> <span class="n">aToggleAnnotator</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">KParts</span><span style="color: #aa2211">::</span><span class="n">MainWindow</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">KParts</span><span style="color: #aa2211">::</span><span class="n">MainWindow</span><span style="color: #aa2211">::</span><span class="n">memberList</span><span class="p">()[</span><span style="color: #601200">0</span><span class="p">])</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span style="color: #aa2211">-></span><span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">action</span><span class="p">(</span> <span style="color: #766510">"mouse_toggle_annotate"</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This implementation is buggy. How to detect in which main window are we?  (Even if we move <tt style="background: #ebebeb; font-size: 13px;">aToggleAnnotator</tt> to <tt style="background: #ebebeb; font-size: 13px;">part.rc</tt> I think we still need to figure out in which part are we, so should not give any benefit)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>BRANCH</strong><div><div>new-annotation-toolbar_ToggleActionMenu</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15580">https://phabricator.kde.org/D15580</a></div></div><br /><div><strong>To: </strong>simgunz, Okular, VDG, ngraham<br /><strong>Cc: </strong>andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen<br /></div>