<table><tr><td style="">ndavis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22617">View Revision</a></tr></table><br /><div><div><p>I'll give the latest changes a proper review in a little while.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22617#500046" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22617#500046</a>, <a href="https://phabricator.kde.org/p/davidhurka/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidhurka</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.</p></div>
</blockquote>
<p>Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG standard for coloring symbolic/monochrome icons will fix that and then we can drop icons-dark.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>And I’m a bit concerned that scour-icon removes the id="currentColorScheme" attribute from the stylesheet. How do I avoid that?</p></blockquote>
<p>Hm, you could try removing <tt style="background: #ebebeb; font-size: 13px;">--enable-id-stripping</tt> and <tt style="background: #ebebeb; font-size: 13px;">--shorten-ids</tt> from the command. If anything from <a href="https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips" class="remarkup-link" target="_blank" rel="noreferrer">this page</a> confuses you or doesn't work, be sure to post in the Discussion section. Writing documentation isn't a strength of mine, but it's something that has to be done.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22617">https://phabricator.kde.org/D22617</a></div></div><br /><div><strong>To: </strong>davidhurka, VDG, ndavis<br /><strong>Cc: </strong>Okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns<br /></div>