<table><tr><td style="">stevenv added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22259">View Revision</a></tr></table><br /><div><div><p>Apologies for the slightly delayed response, I have been (and still am) traveling. I will try to reply to comments in order.</p>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22259#490959" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22259#490959</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Unless you can give me empirical data that people prefer what you suggest i don't see the point in a change.</p></div>
</blockquote>
<p>The best data I can offer would be the Okular menu itself, and the rest of the KDE applications.</p>
<p>48px icons are defined as "Large" in the menu, which generally means "Larger than the default" so it is unintuitive to set it as the default.</p>
<p>In many other KDE applications the default icon size is even smaller than the 32px "Normal" setting in Okular, commonly 22px as in Dolphin, Ark, etc.<br />
So not only is the setting unintuitive, but also distinctly out of place when compared.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22259#490959" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22259#490959</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>All this is configurable, people can choose whatever they want.</p></div>
</blockquote>
<p>Sane defaults are very important.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22259#490959" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22259#490959</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Also please use invent.kde.org in the future for Okular merge requests.</p></div>
</blockquote>
<p>My apologies I didn't know about this, thank you for pointing it out! I really like GitLab and am glad to see KDE use it.</p>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22259#490963" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22259#490963</a>, <a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>You'd be surprised how often people forget that tooltips exist, even after being reminded many times. It's not that they aren't smart enough to remember, they just aren't that into computers.</p></div>
</blockquote>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22259#491359" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22259#491359</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Same. Icons-only buttons only work when their icons are universally-recognizable and have a meaning that's100% clear. I don't think we can say that about this sidebar. Vertical text isn't a great idea either. Also keep in mind that tooltips aren't available on touch, because there's no concept of hover.</p></div>
</blockquote>
<p>You both bring up very good points, and I agree that the tooltips are not an adequate replacement for the inline text.<br />
However the text is the widest element in the sidebar and the only way to make the sidebar thinner is to either hide the text or move/change it.<br />
We seem to have come to the consensus that vertical text is not the option, but there might be another possibility that has not occurred to me so any suggestions would be appreciated.</p>
<p>Ultimately the usability of any visual sidebar change is up to the VDG and if it is their decision that the text must stay the way it is, then please feel free to close this patch.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22259">https://phabricator.kde.org/D22259</a></div></div><br /><div><strong>To: </strong>stevenv, Okular, VDG, ngraham<br /><strong>Cc: </strong>ngraham, aacid, ndavis, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen<br /></div>