<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22064">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22064#inline-124340">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationwidgets.cpp:153</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">customStampFile</span> <span style="color: #aa2211">=</span> <span class="n">QFileDialog</span><span style="color: #aa2211">::</span><span class="n">getOpenFileName</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Select custom stamp symbol"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QString</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"*.ico *.png *.xpm *.svg *.svgz | Icon Files (*.ico *.png *.xpm *.svg *.svgz)"</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span> <span style="color: #aa2211">!</span><span class="n">customStampFile</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Are you sure the list of file formats should be localized?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22064#inline-124341">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationwidgets.cpp:425</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_pixmapSelector</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">PixmapPreviewSelector</span><span class="p">(</span> <span class="n">widget</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_pixmapSelector</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">PixmapPreviewSelector</span><span class="p">(</span> <span class="n">widget<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">true</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">/* previewBelow */</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">formlayout</span><span style="color: #aa2211">-></span><span class="n">addRow</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Stamp symbol:"</span> <span class="p">),</span> <span class="n">m_pixmapSelector</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If this was an enum, you wouldn't need to add an inline comment explaining what it does :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22064#inline-124338">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationwidgets.h:35</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #a0a000">public</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">explicit</span> <span class="n">PixmapPreviewSelector</span><span class="p">(</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span> <span class="n">parent</span> <span style="color: #aa2211">=</span> <span class="n">nullptr</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">explicit</span> <span class="n">PixmapPreviewSelector</span><span class="p">(</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span> <span class="n">parent</span> <span style="color: #aa2211">=</span> <span class="n">nullptr<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">previewBelow</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">false</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">virtual</span> <span style="color: #aa2211">~</span><span class="n">PixmapPreviewSelector</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Instead of adding a new bool argument, how about an enum instead for clarity so the code is easy to read?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22064">https://phabricator.kde.org/D22064</a></div></div><br /><div><strong>To: </strong>simgunz, Okular<br /><strong>Cc: </strong>yurchor, ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid<br /></div>