<table><tr><td style="">davidhurka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21755">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D21755#482891" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D21755#482891</a>, <a href="https://phabricator.kde.org/p/simgunz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@simgunz</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I tried it by only adding the actions to it and it does not work, no menu is shown. Adding the signal connection is also not enough. After that I gave up for now (I am lazy). But I think it needs to be a little more user-friendly.</p></div>
</blockquote>
<p>I tried to reproduce that with the current revision (i. e. with QObject* as parent, but without configuration options, i. e. <a href="https://phabricator.kde.org/D21755?id=60141" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D21755?id=60141</a>), but it worked.</p>
<p>In pageview.cpp, I reduced the code to create the menu to:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #74777d">// Mouse-Mode action menu</span>
<span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseModeMenu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">ToggleActionMenu</span><span class="p">(</span> <span style="color: #aa4000">this</span> <span class="p">);</span>
<span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseModeMenu</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseSelect</span> <span class="p">);</span>
<span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseModeMenu</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseTextSelect</span> <span class="p">);</span>
<span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseModeMenu</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseTableSelect</span> <span class="p">);</span>
<span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseModeMenu</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span> <span class="n">i18nc</span><span class="p">(</span> <span style="color: #766510">"@action"</span><span class="p">,</span> <span style="color: #766510">"Selection Tools"</span> <span class="p">)</span> <span class="p">);</span>
<span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span> <span style="color: #766510">"mouse_selecttools"</span> <span class="p">),</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aMouseModeMenu</span> <span class="p">);</span></pre></div>
<p>Result: Toolbar button is boringly titled “Selection Tools”, but click-and-hold opens the menu. Actions in the menu work.</p>
<p>Also removing the last two lines causes the ToggleActionMenu not to be pluggable in the toolbar anymore.</p>
<p>I conclude that it <em>can</em> work. Did you test it differently?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21755">https://phabricator.kde.org/D21755</a></div></div><br /><div><strong>To: </strong>davidhurka, Okular<br /><strong>Cc: </strong>simgunz, aacid, VDG, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen<br /></div>