<table><tr><td style="">davidhurka edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-4hdgwuef35ydhgl/">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21755">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>[<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">x] Load correct selection tool from configuration at startup, //after// mouseModeMenu is created.</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">] Load correct selection tool from configuration at startup</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">(Difficult</span>, <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">//after// mouseModeMenu is created.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">but done another way now.)</span><br />
[x] Fix crash at destruction<br />
[<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">x] Better name than ToggleActionMenu?</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">] Better name than ToggleActionMenu?</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">ToolAction was probably better.</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">ToolAction was probably better.. :-/</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">(Added description for the name.)</span><br />
[ ] License headers. (I’ve seen that mailing list thread, yes... :-/ )<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
[ ] Disable the toolbar button when the menu itself is disabled. (KActionMenu doesn’t need this, because it shows itself on the toolbar button.)<br />
[ ] Tooltips needed?</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21755">https://phabricator.kde.org/D21755</a></div></div><br /><div><strong>To: </strong>davidhurka, Okular<br /><strong>Cc: </strong>simgunz, aacid, VDG, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen<br /></div>