<table><tr><td style="">tobiasdeiminger added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21836">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21836#inline-123396">View Inline</a><span style="color: #4b4d51; font-weight: bold;">presentationwidget.cpp:900</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QPixmap</span> <span style="color: #004012">pm</span><span class="p">(</span> <span class="n">geom</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QPixmap</span> <span style="color: #004012">pm</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">QSize</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">geom</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">size</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">width</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">dpr</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">geom</span><span class="p">.</span><span class="n">size</span><span class="p">(<span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">height</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">dpr</span></span><span class="bright"> </span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">pm</span><span class="p">.</span><span class="n">fill</span><span class="p">(</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">transparent</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe use a scoped</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QSizeF pmSize { geom.width() * dpr, geom.height() * dpr };</pre></div>

<p style="padding: 0; margin: 8px;">instead of repeatedly recalculating width and height?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21836#inline-123399">View Inline</a><span style="color: #4b4d51; font-weight: bold;">presentationwidget.cpp:1329</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"> </span><span class="n"><span class="bright">nX</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"></span><span class="n"><span class="bright">e</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"></span><span class="n"><span class="bright">geom</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">left</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"></span><span class="n"><span class="bright">geom</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">width</span></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">double</span> <span class="n">n<span class="bright">Y</span></span> <span style="color: #aa2211">=</span> <span class="p">(</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"></span><span class="n"><span class="bright">e</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">y</span></span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa4000">double</span><span class="p">)</span><span class="n">geom</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">top</span></span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span class="p">(</span><span style="color: #aa4000">double</span><span class="p">)</span><span class="n">geom</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">height</span></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">QPointF</span></span><span class="bright"> </span><span class="n"><span class="bright">mousePos</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">e</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">screenPos</span></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">double</span> <span class="n">n<span class="bright">X</span></span> <span style="color: #aa2211">=</span> <span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">mousePos</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa4000">double</span><span class="p">)</span><span class="n">geom</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">left</span></span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span class="p">(</span><span style="color: #aa4000">double</span><span class="p">)</span><span class="n">geom</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">width</span></span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this change necessary? Conversion to <tt style="background: #ebebeb; font-size: 13px;">double</tt> was already there. <tt style="background: #ebebeb; font-size: 13px;">screenPos()</tt> would change semantic from "relative to widget" to "relative to screen". Doesn't matter because widget is probably always full screen. But otoh the whole thing is called <tt style="background: #ebebeb; font-size: 13px;">PresentationWidget</tt>, so keeping "relative to widget" seems reasonable.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21836">https://phabricator.kde.org/D21836</a></div></div><br /><div><strong>To: </strong>sander, Okular, ngraham, tobiasdeiminger<br /><strong>Cc: </strong>okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid<br /></div>