<table><tr><td style="">davidhurka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20437">View Revision</a></tr></table><br /><div><div><p>Sorry for testing it so late, now that I’m working on PageView.</p>

<p>I don’t like this much, see inline comment. Do you mind if I change it to error accumulation at some time?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20437#inline-122021">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageview.cpp:3760</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">pos</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">horizontalScrollBar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">value</span><span class="p">())</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">dragScrollVector</span><span class="p">.</span><span class="n">setX</span><span class="p">((</span><span class="n">pos</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">horizontalScrollBar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">value</span><span class="p">())</span><span style="color: #aa2211">/</span><span class="n">damping</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">horizontalScrollBar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">value</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">viewport</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">pos</span><span class="p">.</span><span class="n">x</span><span class="p">())</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">dragScrollVector</span><span class="p">.</span><span class="n">setX</span><span class="p">((</span><span class="n">pos</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">horizontalScrollBar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">value</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">viewport</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">())</span><span style="color: #aa2211">/</span><span class="n">damping</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is only integer arithmetic, so <tt style="background: #ebebeb; font-size: 13px;">damping = 6</tt> makes the edge scrolling feel a bit coarse. Crossing the edge only 5 pixels does nothing, but dragging only one pixel further gives “full speed”.</p>

<p style="padding: 0; margin: 8px;">I would place <tt style="background: #ebebeb; font-size: 13px;">damping</tt> in slotDragScroll(), which can do smoothing by error accumulation. (Bresenham and so on.... ;) )</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20437">https://phabricator.kde.org/D20437</a></div></div><br /><div><strong>To: </strong>kezik, Okular, aacid, sander, ngraham<br /><strong>Cc: </strong>davidhurka, sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, darcyshen<br /></div>