<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15580">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">The Color button should actually show the current color rather than a generic icon</li>
</ul></blockquote>
<p>This should already work.</p></blockquote>
<p>My mistake, it totally does work!</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">The Inner color button needs something to show that it exists; right now it just looks like whitespace in the toolbar. It should show its color like the other button, and for "no color", maybe an empty transparent square?</li>
</ul></blockquote>
<p>Also the icons of color and inner color need to be done from scratch. I was thinking at a circle fillable with the current color and a border to show it exists.</p></blockquote>
<p>Yep, that sounds good. Also I found out why it looked invisible: its icon disappears when using the Line tool, or any other tool that doesn't have an inner color, and does not restore its icon when using a tool that does have an inner color. It should probably become conditionally and temporarily disabled instead.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item"><span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Straight Line</span></span></span> is mis-named, it's for drawing anything <em>but</em> a straight line! :) Should be something like "Freehand line"</li>
</ul></blockquote>
<p>Have you removed .config/okularpartrc ? Otherwise the toolbar picks up the annotation in you custom orders and the buttons are mismatched.</p></blockquote>
<p>Yep, I did. Did it again for good measure. It still says, "Straight Line": <a href="https://phabricator.kde.org/F6866309" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6866309: Screenshot_20190603_092649.png</a></p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">I can't figure out what <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Pin Annotation</span></span></span> actually does</li>
</ul></blockquote>
<p>If checked the current annotation tool is kept selected after use (as double-click does in the current Okular). Needs a better name/tooltip. Added to TODO.</p></blockquote>
<p>Can't we just keep the old double-click behavior? I think that's good. Various other similar tools use a double-click to mean "activate this tool and then keep it active after you've used it once" so it's not a totally alien UI. Then we could keep the pin icon as an additional visual status indicator of whether the current tool is "sticky" or not.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">It's not clear to me how to select existing annotations once an annotation tool has been activated; consider maybe adding a "select annotations" tool or mode under the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Selection</span></span></span> dropdown menu.</li>
</ul></blockquote>
<p>Currently you need to click Esc to deselect the annotation, then you can select the annotations (standard Browse mode). If instead 'pin annotation' is unchecked, the annotation is deselected automatically and you can select annotation. Beside the fact that clicking on an annotation does not select it (added to TODO) and that selecting and annotation does not switch to Browse mode (added to TODO), it works as the current version of Okular. I think we do not need a dedicated Selection tool.</p></blockquote>
<p>Got it. My first impulse to deselect the currently-active annotation tool was to to click on it again. Currently this does nothing. Maybe it should de-select it.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15580">https://phabricator.kde.org/D15580</a></div></div><br /><div><strong>To: </strong>simgunz, Okular<br /><strong>Cc: </strong>knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid<br /></div>