<table><tr><td style="">davidhurka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10859">View Revision</a></tr></table><br /><div><div><p>Just tried this. Maybe you can bring back the section headings, which were group box labels before? Straight Line got many options recently.</p>
<p>Not working buddys (probably a problem with PixmapPreviewSelector):<br />
Popup-Note -> Icon (Alt + i)<br />
Stamp -> Stamp symbol (Alt + s)<br />
(Another not working accelerator: Configure Okular -> Annotations: Author and Add both have Alt + a.)</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10859#471480" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10859#471480</a>, <a href="https://phabricator.kde.org/p/simgunz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@simgunz</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Regarding the stamp annotation tool, I have aligned the combobox to the top, because I have not found a way to vertically align the label.</p></div>
</blockquote>
<p>Looks ok to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10859#inline-120660">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationwidgets.cpp:378</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">QVBoxLayout</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">lay</span></span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="bright"></span><span class="n"><span class="bright">QVBoxLayout</span></span><span class="p">(</span> <span class="n">widget</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">lay</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setMargin</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QGroupBox</span> <span style="color: #aa2211">*</span> <span class="n">gb</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QGroupBox</span><span class="p">(</span> <span class="n">widget</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">lay</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span> <span class="n">gb</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">gb</span><span style="color: #aa2211">-></span><span class="n">setTitle</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Stamp Symbol"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QHBoxLayout</span> <span style="color: #aa2211">*</span> <span class="n">gblay</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QHBoxLayout</span><span class="p">(</span> <span class="n">gb</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_pixmapSelector</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">PixmapPreviewSelector</span><span class="p">(</span> <span class="n">gb</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">gblay</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span> <span class="n">m_pixmapSelector</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">m_pixmapSelector</span></span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="bright"></span><span class="n"><span class="bright">PixmapPreviewSelector</span></span><span class="p">(</span> <span class="n">widget</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">formlayout</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">addRow</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Stamp symbol:"</span></span><span class="bright"> </span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">m_pixmapSelector</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_pixmapSelector</span><span style="color: #aa2211">-></span><span class="n">setEditable</span><span class="p">(</span> <span style="color: #304a96">true</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Capitalize symbol?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10859#inline-120664">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationwidgets.cpp:379</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">lay</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setMargin</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QGroupBox</span> <span style="color: #aa2211">*</span> <span class="n">gb</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QGroupBox</span><span class="p">(</span> <span class="n">widget</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">lay</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span> <span class="n">gb</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">gb</span><span style="color: #aa2211">-></span><span class="n">setTitle</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Stamp Symbol"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QHBoxLayout</span> <span style="color: #aa2211">*</span> <span class="n">gblay</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QHBoxLayout</span><span class="p">(</span> <span class="n">gb</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_pixmapSelector</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">PixmapPreviewSelector</span><span class="p">(</span> <span class="n">gb</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">gblay</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span> <span class="n">m_pixmapSelector</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">formlayout</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">addRow</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Stamp symbol:"</span></span><span class="bright"> </span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">m_pixmapSelector</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_pixmapSelector</span><span style="color: #aa2211">-></span><span class="n">setEditable</span><span class="p">(</span> <span style="color: #304a96">true</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why is this editable? Entering a path to an image does not work.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10859">https://phabricator.kde.org/D10859</a></div></div><br /><div><strong>To: </strong>simgunz, Okular, VDG, ngraham<br /><strong>Cc: </strong>davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen<br /></div>