<table><tr><td style="">pino added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21202">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21202#inline-119160">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kjs_document.cpp:275-286</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">Page</span> <span style="color: #aa2211">*</span> <span style="color: #a0a000">pIt</span> <span class="p">:</span> <span class="n">doc</span><span style="color: #aa2211">-></span><span class="n">m_pagesVector</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="n">QLinkedList</span><span style="color: #aa2211"><</span> <span class="n">Okular</span><span style="color: #aa2211">::</span><span class="n">FormField</span> <span style="color: #aa2211">*</span> <span style="color: #aa2211">></span> <span class="n">pageFields</span> <span style="color: #aa2211">=</span> <span class="n">pIt</span><span style="color: #aa2211">-></span><span class="n">formFields</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span><span class="p">(</span> <span class="n">Okular</span><span style="color: #aa2211">::</span><span class="n">FormField</span> <span style="color: #aa2211">*</span><span style="color: #a0a000">ffIt</span> <span class="p">:</span> <span class="n">pageFields</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">numField</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This convoluted for loop basically get the i-th element of a QLinkedList, which is not designed for index accessing (and that is why there is no at(int) method).<br />
IMHO a better way is:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">get the list of form fields</li>
<li class="remarkup-list-item">compare the wanted index with the count of the form fields: if it is out of boundaries, return KJSUndefined directly</li>
<li class="remarkup-list-item">otherwise, create an iterator fromthe begin, and increment it by the wanted index to get to the wanted element</li>
</ul></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21202">https://phabricator.kde.org/D21202</a></div></div><br /><div><strong>To: </strong>joaonetto, aacid, Okular<br /><strong>Cc: </strong>pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid<br /></div>