<table><tr><td style="">pino added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20760">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20760#inline-118132">View Inline</a><span style="color: #4b4d51; font-weight: bold;">annotationwidgets.cpp:549-558</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">u</span><span style="color: #766510">"</span><span style="color: #bb6622">\u25A1</span><span style="color: #766510">"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" Square"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">u</span><span style="color: #766510">"</span><span style="color: #bb6622">\u25CB</span><span style="color: #766510">"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" Circle"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">u</span><span style="color: #766510">"</span><span style="color: #bb6622">\u25C7</span><span style="color: #766510">"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" Diamond"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">u</span><span style="color: #766510">"</span><span style="color: #bb6622">\u2192</span><span style="color: #766510">"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" Open Arrow"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">u</span><span style="color: #766510">"</span><span style="color: #bb6622">\u21FE</span><span style="color: #766510">"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" Closed Arrow"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" None"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_termStyleCombo</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">u</span><span style="color: #766510">"</span><span style="color: #bb6622">\u22A3</span><span style="color: #766510">"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">" Butt"</span> <span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think this does not play well with translations: there is nothing that says what for the leading spaces are, so translators can easily not have them in the translations, resulting in symbol and first word attached together.<br />
There is also the issue that some of the strings are no easy to get, for example "Butt" (yes, without context), or "-/ Slash".</p>

<p style="padding: 0; margin: 8px;">My proposal is the following:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">create a QIconEngine that draws a specific character/string as icon; this also makes sure all the symbols and texts are properly aligned</li>
<li class="remarkup-list-item">leave the strings as simple strings with no spaces nor other parts, adding contexts to them</li>
</ul></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20760">https://phabricator.kde.org/D20760</a></div></div><br /><div><strong>To: </strong>knambiar, Okular, VDG, sander, ngraham<br /><strong>Cc: </strong>pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid<br /></div>