<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19717">View Revision</a></tr></table><br /><div><div><p>I'm not very convinced with the tests.</p>
<p>You have \n but the rects are all one after the other, so the algorithm that does the line partition doesn't really see a line there, you should have them in different row rects so that they are actually different physical lines.</p>
<p>The "Across Lines not find" doesn't really test what you want, you "want" to test that it finds the last entry, but since the only thing you're checking is that it finds stuff and not in which rects it finds them, it may very well be finding "ab\na"</p>
<p>Same thing for Hyphen doesn't count</p>
<p>Am i making sense?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19717#inline-112888">View Inline</a><span style="color: #4b4d51; font-weight: bold;">textpage.cpp:867</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">len</span> <span style="color: #aa2211">=</span> <span class="n">stringLengthAdaptedWithHyphen</span><span class="p">(</span><span class="n">str</span><span class="p">,</span> <span class="n">it</span><span class="p">,</span> <span class="n">m_words</span><span class="p">.</span><span class="n">constEnd</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">len</span> <span style="color: #aa2211">=</span> <span class="n">stringLengthAdaptedWithHyphen</span><span class="p">(</span><span class="n">str<span class="bright">NotUsed</span></span><span class="p">,</span> <span class="n">it</span><span class="p">,</span> <span class="n">m_words</span><span class="p">.</span><span class="n">constEnd</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">str</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">(</span><span class="n">strNotUsed</span><span class="p">).</span><span class="n">replace</span><span class="p">(</span><span style="color: #766510">'\n'</span><span class="p">,</span> <span style="color: #766510">' '</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19717#inline-112889">View Inline</a><span style="color: #4b4d51; font-weight: bold;">textpage.cpp:986</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">len</span> <span style="color: #aa2211">=</span> <span class="n">stringLengthAdaptedWithHyphen</span><span class="p">(</span><span class="n">str</span><span class="p">,</span> <span class="n">it</span><span class="p">,</span> <span class="n">m_words</span><span class="p">.</span><span class="n">constEnd</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">len</span> <span style="color: #aa2211">=</span> <span class="n">stringLengthAdaptedWithHyphen</span><span class="p">(</span><span class="n">str<span class="bright">NotUsed</span></span><span class="p">,</span> <span class="n">it</span><span class="p">,</span> <span class="n">m_words</span><span class="p">.</span><span class="n">constEnd</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">str</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">(</span><span class="n">strNotUsed</span><span class="p">).</span><span class="n">replace</span><span class="p">(</span><span style="color: #766510">'\n'</span><span class="p">,</span> <span style="color: #766510">' '</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19717">https://phabricator.kde.org/D19717</a></div></div><br /><div><strong>To: </strong>joaonetto, Okular<br /><strong>Cc: </strong>aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen<br /></div>