<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19123">View Revision</a></tr></table><br /><div><div><p>This needs a test for whole word search.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19123#inline-106572">View Inline</a><span style="color: #4b4d51; font-weight: bold;">textpage.h:144</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                                   <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CaseSensitivity</span> <span class="n">caseSensitivity</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">RegularAreaRect</span> <span style="color: #aa2211">*</span><span class="n">lastRect<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                   <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CaseSensitivity</span> <span class="n">caseSensitivity</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">RegularAreaRect</span> <span style="color: #aa2211">*</span><span class="n">lastRect<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                   <span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">wholeWords</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This breaks binary compatibility <a href="https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B</a></p>

<p style="padding: 0; margin: 8px;">What you want is adding a new function with the new param and make the old one call the new.</p>

<p style="padding: 0; margin: 8px;">You have the same problem in the core/*.h files.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19123">https://phabricator.kde.org/D19123</a></div></div><br /><div><strong>To: </strong>joaonetto, Okular<br /><strong>Cc: </strong>aacid, ngraham, okular-devel, tfella, darcyshen<br /></div>