<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18179">View Revision</a></tr></table><br /><div><div><p>Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18179#inline-100339">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fileprinter.h:82</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                          <span class="n">PageSelectPolicy</span> <span class="n">pageSelectPolicy</span> <span style="color: #aa2211">=</span> <span class="n">FilePrinter</span><span style="color: #aa2211">::</span><span class="n">ApplicationSelectsPages</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                          <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">pageRange</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                          <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">pageRange</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">()<span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">doScaling</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">true</span></span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this is not binary compatible, we try not to break the binary compatibility of the okular public classes.</p>

<p style="padding: 0; margin: 8px;">Add another method (without the default values) and make this one call the new one.</p>

<p style="padding: 0; margin: 8px;">Same for all the functions you're adding new parameters to.</p>

<p style="padding: 0; margin: 8px;">Or you can try to convince me that maintainting binary compatibilty is not needed :D</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18179">https://phabricator.kde.org/D18179</a></div></div><br /><div><strong>To: </strong>michaelweghorn, Okular, ngraham, sander<br /><strong>Cc: </strong>aacid, fvogt, okular-devel, ngraham, darcyshen<br /></div>