<table><tr><td style="">tobiasdeiminger added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15301">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15301#inline-82521">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageviewannotator.cpp:515</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span class="bright"></span><span style="color: #aa4000"><span class="bright">delete</span></span><span class="bright"> </span><span class="n">selection</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span class="n">s<span class="bright">election</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span class="n">Okular</span><span style="color: #aa2211">::</span><span class="n">RegularAreaRect</span> <span style="color: #aa2211">*</span> <span class="n">newselection</span> <span style="color: #aa2211">=</span> <span class="n">m_pageView</span><span style="color: #aa2211">-></span><span class="n">textSelectionForItem</span><span class="p">(</span> <span class="n">item</span><span class="p">(),</span> <span class="n">start</span><span class="p">,</span> <span class="n">end</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">selection<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">reset</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">s<span class="bright">td</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">unique_ptr</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">Okular</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">RegularAreaRect</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="n"><span class="bright">newselection</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">m_pageView</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">textSelectionForItem</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">item</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">start</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">end</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">newselection</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">newselection</span><span style="color: #aa2211">-></span><span class="n">isEmpty</span><span class="p">()</span> <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This assumes <tt style="background: #ebebeb; font-size: 13px;">m_pageView->textSelectionForItem</tt> transfers ownership for the returned <tt style="background: #ebebeb; font-size: 13px;">RegularAreaRect*</tt>. That's actually true, but we can only tell it by looking at the code inside <tt style="background: #ebebeb; font-size: 13px;">TextPage::textArea</tt>.</p>

<p style="padding: 0; margin: 8px;">Would be nice if we could make ownership explicit throughout the call chain. But I'm afraid it's problematic because <tt style="background: #ebebeb; font-size: 13px;">TextPage::textArea</tt> is part of public interface and we don't want to change it?</p>

<p style="padding: 0; margin: 8px;">If you can't change it, just go on. It's not a problem introduced by your patch but already existed before.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15301">https://phabricator.kde.org/D15301</a></div></div><br /><div><strong>To: </strong>sander, Okular<br /><strong>Cc: </strong>tobiasdeiminger, okular-devel, ngraham, aacid<br /></div>